Reduce unintended stripping of _ filename prefix
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that this is rather hurtful to `__mocks__` and such.
🦋 Changeset is good to goLatest commit: 7c6a14b We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
etaoins
approved these changes
Jun 24, 2020
72636c
added a commit
that referenced
this pull request
Jun 26, 2020
This filename manipulation has haunted me as `copyFiles` gets used in more places. #106 tightened up the matching patterns but a target repository _could_ have some legitimate reason for storing a filename with a prefix of `_.` that would still get chomped. Instead, only trigger this logic on `skuba init` of a built-in template. There's no reason to do this on `skuba configure`, and external GitHub-hosted templates shouldn't run into the packaging troubles that necessitate a `_package.json`.
72636c
added a commit
that referenced
this pull request
Jun 26, 2020
This filename manipulation has haunted me as `copyFiles` gets used in more places. #106 tightened up the matching patterns but a target repository _could_ have some legitimate reason for storing a filename with a prefix of `_.` that would still get chomped. Instead, only trigger this logic on `skuba init` of a built-in template. There's no reason to do this on `skuba configure`, and external GitHub-hosted templates shouldn't run into the packaging troubles that necessitate a `_package.json`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that this is rather hurtful to
__mocks__and such.